Abacn commented on code in PR #38284:
URL: https://github.com/apache/beam/pull/38284#discussion_r3139748830
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileBasedSinkTest.java:
##########
@@ -79,6 +81,11 @@
public class FileBasedSinkTest {
@Rule public TemporaryFolder tmpFolder = new TemporaryFolder();
+ @Before
+ public void setUp() {
Review Comment:
This was a regression of #36781. I think we should fix the NPE itself
```
java.lang.NullPointerException: Lineage not initialized.
FileSystems.setDefaultPipelineOptions must be called first.
at
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:1045)
at org.apache.beam.sdk.metrics.Lineage.getSinks(Lineage.java:132)
at
org.apache.beam.sdk.io.FileSystems.reportSinkLineage(FileSystems.java:426)
at
org.apache.beam.sdk.io.FileSystems.reportSinkLineage(FileSystems.java:408)
at
...
```
to make `setDefaultPipelineOptions` not required to access
Lineage.getSources / Lineage.getSinks
cc: @shnapz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
