Eliaaazzz commented on PR #37532: URL: https://github.com/apache/beam/pull/37532#issuecomment-4319816969
@jrmccluskey Thank you for your reviews. I addressed all four points. I removed the separate hard-coded 10 and now reuse _WindowAwareBatchingDoFn._MAX_LIVE_WINDOWS so the two window-aware batching implementations stay aligned. I did not make it a public kwarg, since this is an internal buffering heuristic rather than part of the transform’s user-facing contract. Agreed on the padding-efficiency unit test. I removed it. It was comparing incongruent batching setups and trying to encode a performance claim rather than a deterministic semantic guarantee. The remaining unit tests now focus on deterministic behavior only. I updated the benchmark typing to use collections.abc for Callable / Sequence and native built-in generics for dict / list / tuple. I made the expected sorted batch contents explicit in the test for readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
