AMOOOMA commented on code in PR #38262:
URL: https://github.com/apache/beam/pull/38262#discussion_r3157227855
##########
sdks/python/apache_beam/transforms/async_dofn.py:
##########
@@ -104,6 +113,8 @@ def __init__(
schedule an item. Used in testing to ensure timeouts are met.
id_fn: A function that returns a hashable object from an element. This
will be used to track items instead of the element's default hash.
+ use_asyncio: If true, use asyncio and coroutines to process items. If
+ false, use ThreadPoolExecutor.
Review Comment:
I think mostly in cases of where we want to run CPU intensive work on
threads the default will be better since we only have 1 main event loop in
async mode. But yeah definitely would need to add some more info. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
