Abacn commented on code in PR #38320:
URL: https://github.com/apache/beam/pull/38320#discussion_r3161922492
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileIOTest.java:
##########
@@ -376,6 +350,35 @@ public void testMatchWatchForNewFiles() throws
IOException, InterruptedException
p.run();
}
+ @Test
+ public void testMatchWatchForNewFiles_UnboundedPCollection() {
+ // Additional scenarios for testMatchWatchForNewFiles. Only construct the
pipeline and check
+ // output pcoll
+ final Path watchPath = tmpFolder.getRoot().toPath().resolve("watch");
+
Review Comment:
the enforcement isn't present when there is no runner in classpath, which is
the case for core unit test
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -2448,7 +2448,7 @@ def check_threshold(bad, total, threshold,
window=DoFn.WindowParam):
else:
return result
- def expand_2_72_0(self, pcoll):
+ def expand(self, pcoll):
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
