gemini-code-assist[bot] commented on code in PR #38321:
URL: https://github.com/apache/beam/pull/38321#discussion_r3162043303
##########
sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go:
##########
@@ -156,9 +154,6 @@ func Translate(ctx context.Context, p *pipepb.Pipeline,
opts *JobOptions, worker
return nil, err
}
- if opts.Options.Options == nil {
- opts.Options.Options = make(map[string]string)
- }
opts.Options.Options["experiments"] = strings.Join(opts.Experiments,
",")
Review Comment:
Removing the nil check for `opts.Options.Options` introduces a potential
panic if the map is not initialized. Even if current callers ensure
initialization, keeping this check makes the `Translate` function more robust
against future changes or external calls.
```go
if opts.Options.Options == nil {
opts.Options.Options = make(map[string]string)
}
opts.Options.Options["experiments"] = strings.Join(opts.Experiments,
",")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
