tkaymak opened a new pull request, #38324: URL: https://github.com/apache/beam/pull/38324
First split-out PR from #38255 per @Abacn's review guidance (https://github.com/apache/beam/pull/38255#pullrequestreview-4190129854): > Yeah, I don't expect we can get everything working with oneshot. We can do > the following > - all common file changes (e.g. replace calls already deprecated in Spark 3 > then removed in Spark 4), BeamModulePlugin, requireJavaVersion logics > goes first Three commits, one per bucket: 1. **Replace Scala/shaded-Guava calls deprecated in Spark 3, removed in Spark 4.** 8 shared-base files. JavaConversions → JavaConverters; scala.Serializable → java.io.Serializable; StreamingContext.union(...).toList() to satisfy the immutable.Seq overload; sparkproject.guava → vendor.guava equivalents. 2. **Add Spark 4 hooks to BeamModulePlugin** — spark4_version constant + project.ext export + jackson_module_scala_2_13 library entry. The first two are inert until #38255 lands; the Jackson entry is independently useful. 3. **Numeric isSparkAtLeast helper + requireJavaVersion routing** in spark_runner.gradle and spark_job_server.gradle. Standalone bug fix (lex compare breaks for Spark 3.10+) plus future-proofs Java 17 enforcement for Spark 4 builds. All hunks behaviour-identical on Spark 3.5; no new tests required. CHANGES.md entry added under "New Features / Improvements". Follow-up: rebase #38255 on master once this lands; the Spark 4 module add will be much smaller and easier to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
