gemini-code-assist[bot] commented on code in PR #38335:
URL: https://github.com/apache/beam/pull/38335#discussion_r3164246364
##########
.github/gh-actions-self-hosted-runners/arc/variables.tf:
##########
@@ -90,8 +90,8 @@ variable "main_runner" {
max_replicas = optional(number, 1)
disk_size_gb = optional(number, 100)
webhook_scaling = optional(bool, false)
- runner_image = optional(string,
"summerwind/actions-runner:v2.304.0-ubuntu-20.04-30355f7")
- labels = optional(list(string), ["self-hosted", "ubuntu-20.04","main"])
+ runner_image = optional(string,
"summerwind/actions-runner:v2.334.0-ubuntu-24.04-012f1a5")
+ labels = optional(list(string), ["self-hosted", "ubuntu-24.04","main"])
Review Comment:
For better readability and consistency with the rest of the file, consider
adding a space after the comma in the labels list.
```
labels = optional(list(string), ["self-hosted", "ubuntu-24.04",
"main"])
```
##########
.github/gh-actions-self-hosted-runners/arc/environments/beam.env:
##########
@@ -34,9 +34,9 @@ subnetwork_cidr_range = "10.119.0.0/20"
service_account_id =
"[email protected]"
runner_group = "beam"
main_runner = {
- name = "main-runner"
- runner_image =
"us-central1-docker.pkg.dev/apache-beam-testing/beam-github-actions/beam-arc-runner:d7cd81a1649bc665581951d2330c4b8acd19ed72"
+ name = "main-runner-2404"
machine_type = "e2-standard-16"
+ runner_image =
"us-central1-docker.pkg.dev/apache-beam-testing/beam-github-actions/beam-arc-runner:latest"
Review Comment:
Using the `:latest` tag for the `runner_image` is discouraged in
infrastructure-as-code as it makes deployments non-deterministic and difficult
to roll back. It is recommended to use a specific version tag or a container
image digest, especially since the previous configuration used a specific hash
and the default in `variables.tf` also uses a versioned tag.
##########
.github/gh-actions-self-hosted-runners/arc/environments/beam.env:
##########
@@ -47,43 +47,9 @@ main_runner = {
cpu = "2"
memory = "3Gi"
}
- labels = ["self-hosted", "ubuntu-20.04", "main"]
+ labels = ["self-hosted", "ubuntu-24.04", "main"]
}
additional_runner_pools = [{
Review Comment:
The `max_replicas` and `disk_size_gb` settings from the removed
`main-runner-2404` block (previously at lines 110 and 112) appear to be missing
from this updated `main_runner` configuration. Since the default values in
`variables.tf` are `1` and `100` respectively, omitting these will
significantly reduce the capacity of the main runner pool and may cause disk
space issues for jobs. These should be explicitly set to maintain the intended
configuration for the Ubuntu 24.04 runners.
```
max_replicas = "240"
disk_size_gb = 200
enable_selector = true
enable_taint = true
```
##########
.github/gh-actions-self-hosted-runners/arc/variables.tf:
##########
@@ -119,8 +119,8 @@ variable "additional_runner_pools" {
max_replicas = optional(number, 1)
disk_size_gb = optional(number, 100)
webhook_scaling = optional(bool, false)
- runner_image = optional(string,
"summerwind/actions-runner:v2.304.0-ubuntu-20.04-30355f7")
- labels = optional(list(string), ["self-hosted",
"ubuntu-20.04","changeme"])
+ runner_image = optional(string,
"summerwind/actions-runner:v2.334.0-ubuntu-24.04-012f1a5")
+ labels = optional(list(string), ["self-hosted",
"ubuntu-24.04","changeme"])
Review Comment:
For better readability and consistency with the rest of the file, consider
adding a space after the comma in the labels list.
```
labels = optional(list(string), ["self-hosted", "ubuntu-24.04",
"changeme"])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
