tarun-google commented on code in PR #37974:
URL: https://github.com/apache/beam/pull/37974#discussion_r3171323527
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -595,8 +595,9 @@ def _stage_resources(self, pipeline, options):
else:
remote_name = os.path.basename(type_payload.path)
is_staged_role = False
-
- if self._enable_caching and not type_payload.sha256:
+ # compute sha256 even if caching is disabled.
+ # This is used to check the payload integrity along with caching.
+ if not type_payload.sha256:
Review Comment:
I preferred adding sha256 irrespective of flag(as proto already expecting
it) and disabled it during validations. Java already follow the same
conventions. I can update if you are strongly aligned with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
