ibzib edited a comment on pull request #12907:
URL: https://github.com/apache/beam/pull/12907#issuecomment-698639060
- The pattern `LOG.info("foo {} {}", bar, exception)` is technically
correct. But the checker rejects it so I changed these instances to
`LOG.info(String.format("foo %s", bar), exception)`, which disobeys the below.
So I'm thinking maybe the best solution is to enable `LOG.info("foo {} {}",
bar, exception)` upstream (see
https://github.com/KengoTODA/errorprone-slf4j/issues/45). But then they'd have
to make a new release of the plugin, and it'd be incompatible with Java 8
without additional changes...
- I disabled the check that the string format must be constant, since we
disobey that one frequently.
https://github.com/apache/beam/blob/1574a81e99ebe5d1f087f239d4aadc016073a587/sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowTracing.java#L30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
