jrmccluskey commented on code in PR #38334: URL: https://github.com/apache/beam/pull/38334#discussion_r3183149235
########## sdks/python/ruff.toml: ########## @@ -56,7 +56,7 @@ target-version = "py310" src = ["apache_beam"] [lint] -select = ["E9", "PL", "F821", "F822", "F823"] +select = ["E9", "PL", "F821", "F822", "F823", "UP006"] Review Comment: Standardization as far as PEP 585 compliance, gets us off these types that are slated for removal from Python (although there's some waffling about when exactly this will happen, the earliest listed date was actually Python 3.9's EoL / 3.14's release.) This will also spare me, personally, from writing "use the built-in types and not the typing types" on every PR. Related to this point, I found that the gemini code assist was not particularly useful for identifying problems with type hints (the roughly 30 comments prior to your invocation all complained that I was making changes that were not compatible with Python 3.8 and 3.9.) So really this just pushes Beam towards best practices both within the repo and via linting rule all at once, rather than the module-by-module migration I had been doing in my spare time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
