gemini-code-assist[bot] commented on code in PR #38339:
URL: https://github.com/apache/beam/pull/38339#discussion_r3190551094
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/storage/GcsMatchIT.java:
##########
@@ -134,8 +134,12 @@ public Void apply(Iterable<Metadata> input) {
assertEquals(1, countFirst);
// file "second" is expected to appear more than once
assertEquals(true, countSecond > 1);
- // file "second" is expected to appear in growing sizes each time by one
byte
- assertEquals((maxSecondSize * 2L - countSecond + 1) * countSecond / 2,
sumSecondSize);
+ // Continuous matching sometimes skips a middle size on Dataflow; sum
should still fit
+ // between "all sizes seen" and "every size from 1..maxSecondSize".
+ long minPossibleSum = (countSecond - 1) * countSecond / 2 +
maxSecondSize;
Review Comment:
The expression `(countSecond - 1) * countSecond` is susceptible to integer
overflow if `countSecond` is an `int` and its value is large (e.g., > 46,340).
Given that the following line uses `2L` to ensure `long` arithmetic, it is
recommended to use a `long` literal or cast here as well to ensure the
multiplication is performed in 64-bit precision before the division and
addition.
```suggestion
long minPossibleSum = (long) (countSecond - 1) * countSecond / 2 +
maxSecondSize;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
