damccorm commented on code in PR #38110:
URL: https://github.com/apache/beam/pull/38110#discussion_r3196058473
##########
.github/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml:
##########
@@ -91,7 +91,7 @@ jobs:
- name: run PreCommit Yaml Xlang Direct script
uses: ./.github/actions/gradle-command-self-hosted-action
with:
- gradle-command: :sdks:python:yamlIntegrationTests
-PbeamPythonExtra=ml_test,yaml
+ gradle-command: :sdks:python:yamlIntegrationTests
-PbeamPythonExtra=ml_test,yaml,transformers
Review Comment:
Doesn't have to happen in this PR, but is there a reason we can't just
install these as part of the task by default?
Relatedly, I think we need this here as well:
https://github.com/apache/beam/blob/d6b98ba9019de837e07990b706459c6df8321a2f/.github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml#L83
##########
sdks/python/apache_beam/ml/inference/huggingface_inference.py:
##########
@@ -32,7 +32,11 @@
import torch
from transformers import AutoModel
from transformers import Pipeline
-from transformers import TFAutoModel
+
+try:
+ from transformers import TFAutoModel
Review Comment:
What's special about TFAutoModel such that we now need to special case it,
but not the other transformers imports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
