tvalentyn commented on PR #37377:
URL: https://github.com/apache/beam/pull/37377#issuecomment-4392831925

   > Hey, this PR actually breaks the Dataflow protos in python by changing 
field numbers for existing fields
   
   I think apitools generates the fields in the proto alphabetically, and the 
order likely is not material for the underlying JSON api; we made similar 
updates in   https://github.com/apache/beam/pull/37581/changes and earlier 
changes. 
   
   Did something get broken by this PR when it was merge or we reverted out of 
caution?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to