gemini-code-assist[bot] commented on code in PR #38382: URL: https://github.com/apache/beam/pull/38382#discussion_r3198647498
########## .agent/skills/yaml-development/SKILL.md: ########## @@ -0,0 +1,107 @@ +--- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: yaml-development +description: Guides YAML SDK development in Apache Beam, including environment setup, testing, and key concepts. Use when working with Beam YAML code in sdks/python/apache_beam/yaml/. +--- + +# YAML Development in Apache Beam + +## Project Structure + +### Key Files in `sdks/python/apache_beam/yaml/` +- `integration_tests.py` - Runs integration tests defined in YAML files or using testcontainers. +- `main.py` - Entry point for running YAML pipelines from the command line. +- `pipeline.schema.yaml` - JSON schema defining the valid structure for Beam YAML pipelines. +- `standard_io.yaml` - Declarations of standard IO transforms and their mappings to providers. +- `standard_providers.yaml` - Configuration for standard providers (e.g., Java expansion services). +- `yaml_combine.py` - Implementations for aggregation and combining operations. +- `yaml_io.py` - Python implementations for builtin IOs (PubSub, BigQuery, Iceberg, etc.). +- `yaml_join.py` - Implementations for join operations. +- `yaml_mapping.py` - Implementations for mapping operations (e.g., `MapToFields`). +- `yaml_provider.py` - Manages providers (Python, Java cross-language) that implement transforms. +- `yaml_transform.py` - Core YAML expansion logic, parsing, and translation to Beam pipelines. + +## Environment Setup +Since Beam YAML is implemented within the Python SDK, the environment setup is identical to Python development. Refer to the `python-development` skill for details on using `pyenv` and installing in editable mode (`pip install -e .[gcp,test]`). Review Comment:  The `pip install` command should be executed from the `sdks/python` directory for the relative path `.` to be correct. Since the rest of this guide uses paths relative to the repository root, it is clearer to provide the command that works from the root. ```suggestion Since Beam YAML is implemented within the Python SDK, the environment setup is identical to Python development. Refer to the python-development skill for details on using pyenv and installing in editable mode (e.g., pip install -e sdks/python[gcp,test] from the root). ``` ########## .agent/skills/yaml-development/SKILL.md: ########## @@ -0,0 +1,107 @@ +--- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: yaml-development +description: Guides YAML SDK development in Apache Beam, including environment setup, testing, and key concepts. Use when working with Beam YAML code in sdks/python/apache_beam/yaml/. +--- + +# YAML Development in Apache Beam + +## Project Structure + +### Key Files in `sdks/python/apache_beam/yaml/` +- `integration_tests.py` - Runs integration tests defined in YAML files or using testcontainers. +- `main.py` - Entry point for running YAML pipelines from the command line. +- `pipeline.schema.yaml` - JSON schema defining the valid structure for Beam YAML pipelines. +- `standard_io.yaml` - Declarations of standard IO transforms and their mappings to providers. +- `standard_providers.yaml` - Configuration for standard providers (e.g., Java expansion services). +- `yaml_combine.py` - Implementations for aggregation and combining operations. +- `yaml_io.py` - Python implementations for builtin IOs (PubSub, BigQuery, Iceberg, etc.). Review Comment:  The description of `yaml_io.py` as containing "Python implementations" for IOs like Iceberg is inaccurate. Iceberg is implemented in Java and accessed via cross-language providers. `yaml_io.py` primarily contains the logic for the IO provider and mappings to various implementations. ```suggestion - yaml_io.py - Mappings and logic for IO transforms (e.g., PubSub, BigQuery, Iceberg). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
