acrites commented on code in PR #38346:
URL: https://github.com/apache/beam/pull/38346#discussion_r3211759977
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/SplittableProcessElementInvoker.java:
##########
@@ -50,12 +51,27 @@ public Result(
@Nullable RestrictionT residualRestriction,
DoFn.ProcessContinuation continuation,
@Nullable Instant futureOutputWatermark,
- @Nullable WatermarkEstimatorStateT futureWatermarkEstimatorState) {
+ @Nullable WatermarkEstimatorStateT futureWatermarkEstimatorState,
+ double backlogBytes) {
checkArgument(continuation != null, "continuation must not be null");
this.continuation = continuation;
this.residualRestriction = residualRestriction;
this.futureOutputWatermark = futureOutputWatermark;
this.futureWatermarkEstimatorState = futureWatermarkEstimatorState;
+ this.backlogBytes = backlogBytes;
+ }
+
+ public Result(
+ @Nullable RestrictionT residualRestriction,
+ DoFn.ProcessContinuation continuation,
+ @Nullable Instant futureOutputWatermark,
+ @Nullable WatermarkEstimatorStateT futureWatermarkEstimatorState) {
+ this(
+ residualRestriction,
+ continuation,
+ futureOutputWatermark,
+ futureWatermarkEstimatorState,
+ -1.0);
Review Comment:
Good point. I made a dedicated constant in Result for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
