shunping commented on code in PR #38423:
URL: https://github.com/apache/beam/pull/38423#discussion_r3212048907
##########
sdks/python/apache_beam/utils/subprocess_server_test.py:
##########
@@ -302,6 +302,130 @@ def test_interleaved_owners(self):
self.assertNotEqual(cache.get('b'), b)
cache.purge(owner3)
+ def test_destructor_exception_partial_state(self):
+ # In SubprocessServer.stop_process(), we need to make sure self._owner_id
is always
+ # set to None if it is not already set, even if a destructor exception
happens
+ # during purge(owner_id).
+
+ destructor_calls = []
+
+ def faulty_destructor(obj):
+ destructor_calls.append(obj)
+ raise RuntimeError("Destructor failed")
+
+ custom_cache = subprocess_server._SharedCache(
+ lambda *args: "process_obj", faulty_destructor)
+
+ class CustomServer(subprocess_server.SubprocessServer):
+ _cache = custom_cache
+
+ def __init__(self):
+ super().__init__(lambda channel: None, ["dummy_cmd"], port=12345)
+
+ server = CustomServer()
+ server.start_process()
+ owner_id = server._owner_id
+ self.assertIsNotNone(owner_id)
+ self.assertIn(owner_id, custom_cache._live_owners)
+
+ # First stop attempt fails in the destructor
+ with self.assertRaises(RuntimeError):
+ server.stop_process()
+
+ # Verify fixed state: owner is purged from cache set, AND self._owner_id
is successfully cleared to None
+ self.assertNotIn(owner_id, custom_cache._live_owners)
+ self.assertIsNone(server._owner_id)
+
+ # Second stop attempt safely does nothing (no ValueError raised)
+ try:
+ server.stop_process()
+ except ValueError:
+ self.fail("ValueError should not be raised here.")
+
+ def test_duplicate_atexit_registration_on_restart(self):
+ # Make sure we don't have duplicate atexit registration when reusing a
+ # StopOnExistJobServer instance.
+ from unittest.mock import patch
+ import atexit
+ from apache_beam.runners.portability import job_server
Review Comment:
Done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
