derrickaw commented on PR #38362: URL: https://github.com/apache/beam/pull/38362#issuecomment-4413270473
> * there is a lot of commits on this pr, before submitting a PR for review you can squash commits, unless you think it would be helpful to review individual commits I hear what you are saying and I will try to squash more commits next time. I do like having that history and be able to look back at what I did sometimes. > * between review iterations there is no need to rebase, unless there are merge conflicts; you can add new commits to the branch (without squashing new, unreviewed commits into reviewed commits); then github makes it easier to review commits that were added since the last review iteration I hear you - I was hitting a new failure and wanted to see if anything changed after rebasing. I will try to minimizing rebasing in the future. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
