gemini-code-assist[bot] commented on code in PR #38431:
URL: https://github.com/apache/beam/pull/38431#discussion_r3215883031
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/MetadataPropagationTest.java:
##########
@@ -80,8 +80,13 @@ public void testMetadataPropagationAcrossShuffleParameter() {
pipeline.run();
}
+ /**
+ * Tests metadata propagation for a parameter. Note: PAssert internally
introduces a GroupByKey.
+ * This test works only with DirectRunner and runners that support metadata
propagation.
Review Comment:
The Javadoc states that the test works with runners that support "metadata
propagation". However, as noted in the PR description, the specific limitation
in Prism is metadata propagation **across GroupByKey**. Since Prism supports
metadata propagation in other contexts but fails here due to `PAssert`'s
internal use of `GroupByKey`, it would be more accurate to specify this
distinction. Additionally, consider adding a `TODO` with a link to a tracking
issue for Prism's support of this feature to ensure it can be re-enabled later.
```suggestion
* This test works only with DirectRunner and runners that support
metadata propagation across GroupByKey.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
