Abacn commented on code in PR #38440:
URL: https://github.com/apache/beam/pull/38440#discussion_r3219968098
##########
sdks/java/container/Dockerfile:
##########
@@ -24,22 +24,21 @@ ARG TARGETARCH
ARG pull_licenses
-ADD target/slf4j-api.jar /opt/apache/beam/jars/
-ADD target/slf4j-jdk14.jar /opt/apache/beam/jars/
-ADD target/jcl-over-slf4j.jar /opt/apache/beam/jars/
-ADD target/log4j-over-slf4j.jar /opt/apache/beam/jars/
-ADD target/log4j-to-slf4j.jar /opt/apache/beam/jars/
-ADD target/beam-sdks-java-harness.jar /opt/apache/beam/jars/
-
-# Required to use jamm as a javaagent to get accurate object size measuring
-# COPY fails if file is not found, so use a wildcard for open-module-agent.jar
-# since it is only included in Java 9+ containers
-COPY target/jamm.jar target/open-module-agent.jar /opt/apache/beam/jars/
-
-COPY target/${TARGETOS}_${TARGETARCH}/boot /opt/apache/beam/
-
-COPY target/LICENSE /opt/apache/beam/
-COPY target/NOTICE /opt/apache/beam/
+# Dependency jars
+COPY target/slf4j-api.jar \
+ target/slf4j-jdk14.jar \
+ target/jcl-over-slf4j.jar \
+ target/log4j-over-slf4j.jar \
+ target/log4j-to-slf4j.jar \
+ # Required to use jamm as a javaagent to get accurate object size
measuring
+ target/jamm.jar \
+ /opt/apache/beam/jars/
Review Comment:
wrong fact. It's supported and build successfuly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
