shunping commented on code in PR #38432:
URL: https://github.com/apache/beam/pull/38432#discussion_r3221099636
##########
sdks/python/apache_beam/runners/worker/worker_pool_main.py:
##########
@@ -166,6 +167,7 @@ def StartWorker(
worker_id=start_worker_request.worker_id,
state_cache_size=self._state_cache_size,
data_buffer_time_limit_ms=self._data_buffer_time_limit_ms)
+ self._worker_threads[start_worker_request.worker_id] = worker
Review Comment:
This seems unnecessary as the runner is assumed to send different worker ids
to start. We also do not check if the worker id exists in process mode above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
