gemini-code-assist[bot] commented on code in PR #38449:
URL: https://github.com/apache/beam/pull/38449#discussion_r3221348298
##########
runners/spark/job-server/spark_job_server.gradle:
##########
@@ -307,5 +307,7 @@ createCrossLanguageValidatesRunnerTask(
)
shadowJar {
- outputs.upToDateWhen { false }
+ manifest {
+ attributes(["Multi-Release": true])
+ }
}
Review Comment:
This pull request combines two logically separate changes:
1. Removing the Gradle cache workaround (`outputs.upToDateWhen { false }`).
2. Enabling the `Multi-Release` manifest attribute.
Combining unrelated changes in a single pull request can make the commit
history harder to follow and complicates tasks like reverting or cherry-picking
commits. It is recommended to submit separate pull requests for each distinct
logical change.
Please consider splitting these changes into two separate pull requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
