shunping commented on code in PR #38455:
URL: https://github.com/apache/beam/pull/38455#discussion_r3227084242
##########
sdks/python/apache_beam/utils/subprocess_server.py:
##########
@@ -91,7 +91,11 @@ def purge(self, owner):
to_delete = []
with self._lock:
if owner not in self._live_owners:
- raise ValueError(f"{owner} not in {self._live_owners}")
+ _LOGGER.warning(
+ "Subprocess owner %s already purged. If this occurs during atexit "
+ "shutdown, the subprocess was already cleaned up earlier.",
+ owner)
+ return
Review Comment:
This is not common during shutdown. The situation is harmless but would be
great to log it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
