gemini-code-assist[bot] commented on code in PR #38500:
URL: https://github.com/apache/beam/pull/38500#discussion_r3242485644
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -117,6 +117,14 @@ dependencies {
configurations.all {
// iceberg-core needs avro:1.12.0
resolutionStrategy.force 'org.apache.avro:avro:1.12.0'
+ // bigdataoss:gcs-connector and parquet:parquet-hadoop have conflicts with
global hadoop-common:3.4.2
+ // upgrading gcs-connector to 4.0.0 would be fine, because it uses
hadoop-common 3.4.2
+ // but parquet-hadoop is still at 3.3.0
+ // so for now we need to pin hadoop to 3.3.6 until parquet-hadoop releases a
version that uses hadoop 3.4.2+
+ resolutionStrategy.force 'org.apache.hadoop:hadoop-common:3.3.6'
+ resolutionStrategy.force 'org.apache.hadoop:hadoop-client:3.3.6'
+ resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs:3.3.6'
+ resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs-client:3.3.6'
Review Comment:
The Hadoop version `3.3.6` is hardcoded in multiple places within this file
(lines 62, 124, 125, 126, and 127). To improve maintainability and prevent
potential version mismatches during future updates, it is recommended to define
a local variable for the Hadoop version and reuse it throughout the script.
```
def hadoopVersion = "3.3.6"
resolutionStrategy.force "org.apache.hadoop:hadoop-common:$hadoopVersion"
resolutionStrategy.force "org.apache.hadoop:hadoop-client:$hadoopVersion"
resolutionStrategy.force "org.apache.hadoop:hadoop-hdfs:$hadoopVersion"
resolutionStrategy.force
"org.apache.hadoop:hadoop-hdfs-client:$hadoopVersion"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
