gemini-code-assist[bot] commented on code in PR #38502:
URL: https://github.com/apache/beam/pull/38502#discussion_r3243739846
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -59,7 +59,7 @@ dependencies {
implementation "org.apache.iceberg:iceberg-parquet:$iceberg_version"
implementation "org.apache.iceberg:iceberg-orc:$iceberg_version"
implementation "org.apache.iceberg:iceberg-data:$iceberg_version"
- implementation library.java.hadoop_common
+ implementation "org.apache.hadoop:hadoop-common:3.3.6"
Review Comment:
The dependency `hadoop-common` is hardcoded to version `3.3.6` here, while
`hadoop_client` on line 74 continues to use the `library.java` catalog. Since
`resolutionStrategy.force` is applied later in this file (lines 125-128) to
ensure version `3.3.6` is used across all configurations, it is more consistent
and maintainable to keep using the library catalog here.
```
implementation library.java.hadoop_common
```
##########
sdks/java/io/expansion-service/build.gradle:
##########
@@ -57,6 +57,16 @@ configurations.runtimeClasspath {
// Pin nimbus-jose-jwt to 9.37.4 to fix CVE-2025-53864 (transitive via
hadoop-auth)
resolutionStrategy.force 'com.nimbusds:nimbus-jose-jwt:9.37.4'
+
+ // [iceberg]
+ // bigdataoss:gcs-connector and parquet:parquet-hadoop have conflicts with
global hadoop-common:3.4.2
+ // upgrading gcs-connector to 4.0.0 would be fine, because it uses
hadoop-common 3.4.2
+ // but parquet-hadoop is still at 3.3.0
+ // so for now we need to pin hadoop to 3.3.6 until parquet-hadoop releases a
version that uses hadoop 3.4.2+
+ resolutionStrategy.force 'org.apache.hadoop:hadoop-common:3.3.6'
+ resolutionStrategy.force 'org.apache.hadoop:hadoop-client:3.3.6'
+ resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs:3.3.6'
+ resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs-client:3.3.6'
Review Comment:
This block of version pinning and the accompanying comment are duplicated in
`sdks/java/io/iceberg/build.gradle`. To improve maintainability and ensure that
this temporary override is managed in one place, consider defining the Hadoop
version as a variable in a central location (e.g., `BeamModulePlugin` or a
project-level property) and referencing it in both files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
