gemini-code-assist[bot] commented on code in PR #38505:
URL: https://github.com/apache/beam/pull/38505#discussion_r3245654808
##########
sdks/python/setup.py:
##########
@@ -198,7 +198,8 @@ def cythonize(*args, **kwargs):
# Drop this cap once transformers updates the CLIP call site to
# `cls_token=` or tokenizers reinstates `cls=` as a deprecation alias.
'tokenizers<0.23',
- 'torch',
+ # Avoid torch 2.12.0+ which fails to run unit tests with segfault.
+ 'torch<2.12.0',
Review Comment:
The version `2.12.0` for `torch` appears to be a typo. PyTorch is currently
at version 2.5.x, and version 2.12.0 has not been released yet. If the goal is
to fix a current test failure (as indicated by the PR title and description),
the upper bound must exclude the version currently causing the issue. Since all
current versions are less than `2.12.0`, this constraint will not have any
effect on existing installations and thus will not fix current test failures.
Please verify if you meant a version like `2.1.0` or `2.3.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
