gemini-code-assist[bot] commented on code in PR #38514:
URL: https://github.com/apache/beam/pull/38514#discussion_r3249331938
##########
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java:
##########
@@ -600,7 +600,7 @@ private Map<String, TransformProvider>
loadRegisteredTransforms() {
pipeline.getOptions().as(ExperimentalOptions.class), "use_sdf_read");
} else {
LOG.warn(
- "Using use_deprecated_read in portable runners is runner-dependent.
The "
+ "Using use_depreacted_read in portable runners is runner-dependent.
The "
Review Comment:
Typo in log message: "depreacted" should be "deprecated".
```suggestion
"Using use_deprecated_read in portable runners is
runner-dependent. The "
```
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java:
##########
@@ -1333,20 +1333,19 @@ public DataflowPipelineJob run(Pipeline pipeline) {
// with the SDK harness image (which implements Fn API).
//
// The same Environment is used in different and contradictory ways,
depending on whether
- // it is a portable or non-portable job submission.
+ // it is a v1 or v2 job submission.
RunnerApi.Environment defaultEnvironmentForDataflow =
Environments.createDockerEnvironment(workerHarnessContainerImageURL);
- // The SdkComponents for portable and non-portable job submission must be
kept distinct. Both
+ // The SdkComponents for portable an non-portable job submission must be
kept distinct. Both
Review Comment:
Typo in comment: "an" should be "and".
```suggestion
// The SdkComponents for portable and non-portable job submission must
be kept distinct. Both
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
