gemini-code-assist[bot] commented on code in PR #38517:
URL: https://github.com/apache/beam/pull/38517#discussion_r3249357840
##########
sdks/java/io/expansion-service/build.gradle:
##########
@@ -59,10 +59,8 @@ configurations.runtimeClasspath {
resolutionStrategy.force 'com.nimbusds:nimbus-jose-jwt:9.37.4'
// [iceberg]
- // bigdataoss:gcs-connector and parquet:parquet-hadoop have conflicts with
global hadoop-common:3.4.2
- // upgrading gcs-connector to 4.0.0 would be fine, because it uses
hadoop-common 3.4.2
- // but parquet-hadoop is still at 3.3.0
- // so for now we need to pin hadoop to 3.3.6 until parquet-hadoop releases a
version that uses hadoop 3.4.2+
+ // TODO(https://github.com/apache/beam/issues/38515):
+ // Remove below pins when parquet-hadoop upgrades to hadoop-common:3.4.2
Review Comment:
The updated comment removes the context regarding the conflict with
`gcs-connector`. It is better to keep a brief explanation of the conflict in
the code so developers understand the reasoning for these pins without needing
to visit the external link. Additionally, the second line has an extra space in
its indentation.
```
// TODO(https://github.com/apache/beam/issues/38515): Remove below pins
when parquet-hadoop
// upgrades to hadoop-common:3.4.2 (conflicts with gcs-connector and
parquet-hadoop).
```
##########
sdks/java/io/iceberg/build.gradle:
##########
@@ -118,10 +118,8 @@ dependencies {
configurations.all {
// iceberg-core needs avro:1.12.0
resolutionStrategy.force 'org.apache.avro:avro:1.12.0'
- // bigdataoss:gcs-connector and parquet:parquet-hadoop have conflicts with
global hadoop-common:3.4.2
- // upgrading gcs-connector to 4.0.0 would be fine, because it uses
hadoop-common 3.4.2
- // but parquet-hadoop is still at 3.3.0
- // so for now we need to pin hadoop to 3.3.6 until parquet-hadoop releases a
version that uses hadoop 3.4.2+
+ // TODO(https://github.com/apache/beam/issues/38515):
+ // Remove below pins when parquet-hadoop upgrades to hadoop-common:3.4.2
Review Comment:
The updated comment removes the context regarding the conflict with
`gcs-connector`. It is better to keep a brief explanation of the conflict in
the code so developers understand the reasoning for these pins without needing
to visit the external link. Additionally, the second line has an extra space in
its indentation.
```
// TODO(https://github.com/apache/beam/issues/38515): Remove below pins
when parquet-hadoop
// upgrades to hadoop-common:3.4.2 (conflicts with gcs-connector and
parquet-hadoop).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
