pabloem commented on a change in pull request #12918:
URL: https://github.com/apache/beam/pull/12918#discussion_r494501806
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -131,6 +131,12 @@ def get_hashable_destination(destination):
return destination
+def no_retry_on_invalid_input(exn):
+ if isinstance(exn, ValueError):
+ return False
+ return retry.retry_on_server_errors_and_timeout_filter(exn)
Review comment:
I wonder if this should exist under retry.py. Thoughts?
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -131,6 +131,12 @@ def get_hashable_destination(destination):
return destination
+def no_retry_on_invalid_input(exn):
+ if isinstance(exn, ValueError):
+ return False
+ return retry.retry_on_server_errors_and_timeout_filter(exn)
Review comment:
(I mean that whole function)
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -131,6 +131,12 @@ def get_hashable_destination(destination):
return destination
+def no_retry_on_invalid_input(exn):
+ if isinstance(exn, ValueError):
+ return False
+ return retry.retry_on_server_errors_and_timeout_filter(exn)
Review comment:
I was also thinking a positive logical name (e.g. `retry_on_xyz` unlike
`no_retry_on_...`) rather than a negative - but I'm not sure what it could
be... I can think of `retry_if_valid_input_....` or something like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
