gemini-code-assist[bot] commented on code in PR #38520:
URL: https://github.com/apache/beam/pull/38520#discussion_r3251031637
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -859,13 +859,13 @@ class BeamModulePlugin implements Plugin<Project> {
netty_tcnative_boringssl_static :
"io.netty:netty-tcnative-boringssl-static:2.0.52.Final",
netty_transport :
"io.netty:netty-transport:$netty_version",
netty_transport_native_epoll :
"io.netty:netty-transport-native-epoll:$netty_version",
- opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // google_cloud_platform_libraries_bom
sets version
+ opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // opentelemetry-bom sets version
Review Comment:
The comment indicates that `opentelemetry-bom` sets the version, but the
`opentelemetry_bom` entry (line 863) refers to the alpha BOM
(`opentelemetry-bom-alpha`), which does not manage versions for stable
artifacts like `opentelemetry-api`. Since the
`google_cloud_platform_libraries_bom` is no longer used as the version source
here, you should set the version explicitly to ensure correct resolution,
consistent with the change made to `opentelemetry_context` on line 864.
```
opentelemetry_api :
"io.opentelemetry:opentelemetry-api:$opentelemetry_version", // Set version
explicitly
```
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -859,13 +859,13 @@ class BeamModulePlugin implements Plugin<Project> {
netty_tcnative_boringssl_static :
"io.netty:netty-tcnative-boringssl-static:2.0.52.Final",
netty_transport :
"io.netty:netty-transport:$netty_version",
netty_transport_native_epoll :
"io.netty:netty-transport-native-epoll:$netty_version",
- opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // google_cloud_platform_libraries_bom
sets version
+ opentelemetry_api :
"io.opentelemetry:opentelemetry-api", // opentelemetry-bom sets version
opentelemetry_bom :
"io.opentelemetry:opentelemetry-bom-alpha:$opentelemetry_version-alpha", //
alpha required by extensions
- opentelemetry_context :
"io.opentelemetry:opentelemetry-context", //
google_cloud_platform_libraries_bom sets version
+ opentelemetry_context :
"io.opentelemetry:opentelemetry-context:$opentelemetry_version", // Set version
explicitly as it's standalone runtime dep for Beam modules
opentelemetry_gcp_auth :
"io.opentelemetry.contrib:opentelemetry-gcp-auth-extension:$opentelemetry_contrib_version-alpha",
- opentelemetry_sdk :
"io.opentelemetry:opentelemetry-sdk", // google_cloud_platform_libraries_bom
sets version
- opentelemetry_exporter_otlp :
"io.opentelemetry:opentelemetry-exporter-otlp", //
google_cloud_platform_libraries_bom sets version
- opentelemetry_extension_autoconfigure :
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure", //
google_cloud_platform_libraries_bom sets version
+ opentelemetry_sdk :
"io.opentelemetry:opentelemetry-sdk", // opentelemetry-bom sets version
+ opentelemetry_exporter_otlp :
"io.opentelemetry:opentelemetry-exporter-otlp", // opentelemetry-bom sets
version
+ opentelemetry_extension_autoconfigure :
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure", //
opentelemetry-bom sets version
Review Comment:
These stable OpenTelemetry artifacts are also missing explicit versions and
cannot rely on the alpha BOM defined in `opentelemetry_bom`. To avoid version
resolution issues or potential mismatches, they should be updated to use
explicit versions, following the pattern established for
`opentelemetry_context` on line 864.
```
opentelemetry_sdk :
"io.opentelemetry:opentelemetry-sdk:$opentelemetry_version", // Set version
explicitly
opentelemetry_exporter_otlp :
"io.opentelemetry:opentelemetry-exporter-otlp:$opentelemetry_version", // Set
version explicitly
opentelemetry_extension_autoconfigure :
"io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:$opentelemetry_version",
// Set version explicitly
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
