arpitjain099 commented on PR #38467:
URL: https://github.com/apache/beam/pull/38467#issuecomment-4464614600

   Two notes on Gemini's review, since it flagged some things that don't 
reproduce:
   
   **1. `urllib3==2.7.0` does exist on PyPI.**
   
   ```
   $ python3 -c "import urllib.request,json; print(sorted(k for k in 
json.loads(urllib.request.urlopen('https://pypi.org/pypi/urllib3/json').read())['releases']
 if k.startswith('2.'))[-5:])"
   ['2.6.0', '2.6.1', '2.6.2', '2.6.3', '2.7.0']
   ```
   
   And the actual tox runs in the failed precommit show the resolver landed on 
`urllib3==2.7.0` cleanly: `grpcio-tools==1.80.0 ... urllib3==2.7.0, 
virtualenv-clone==0.5.7 ...` (from the py314-cloud freeze in run 25814674014).
   
   **2. `sdks/python/container/py312/base_image_requirements.txt` is already on 
`urllib3==2.7.0`** on master (verified via the contents API), so it doesn't 
need an update in this PR.
   
   The visible test failure is 
`apache_beam/utils/multi_process_shared_test.py::MultiProcessSharedSpawnProcessTest::test_transient_connection_error_recovery`,
 which by name looks like a network-flake 
(`test_transient_connection_error_recovery`) rather than an urllib3-related 
failure. Master is green on PreCommit Python (`gh run list --repo apache/beam 
--workflow="PreCommit Python" --branch master --limit 5` shows success/skipped 
only).
   
   A re-run when convenient would probably clear it. Happy to amend if a real 
urllib3 issue surfaces.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to