aIbrahiim commented on code in PR #38525:
URL: https://github.com/apache/beam/pull/38525#discussion_r3261147848
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:
##########
@@ -1801,11 +1801,22 @@ static Object deserializeNode(JsonNode node, Method
method) throws IOException {
return null;
}
- JsonParser parser = new TreeTraversingParser(node, MAPPER);
- parser.nextToken();
-
JsonDeserializer<Object> jsonDeserializer =
getDeserializerForMethod(method);
- return jsonDeserializer.deserialize(parser,
DESERIALIZATION_CONTEXT.copy());
+ if (jsonDeserializer == null) {
+ JavaType javaType = MAPPER.constructType(method.getGenericReturnType());
+ return MAPPER.treeToValue(node, javaType);
+ }
+
+ try {
+ JsonParser parser = new TreeTraversingParser(node, MAPPER);
+ parser.nextToken();
+ return jsonDeserializer.deserialize(parser,
DESERIALIZATION_CONTEXT.copy());
+ } catch (NullPointerException e) {
Review Comment:
ahh right it is not a long term fix, i refactored it and her'es the stack
trace:
java.lang.IllegalArgumentException: Error while populating display data for
component
'org.apache.beam.sdk.options.ProxyInvocationHandler$PipelineOptionsDisplayData':
null
at PipelineOptionsTranslation.toProto(...)
at FlinkJobInvoker.createJobInvocation(...)
...
Caused by: java.lang.NullPointerException
at PipelineOptionsFactory.deserializeNode(PipelineOptionsFactory.java:1813)
at ProxyInvocationHandler.getValueFromJson(...)
at
ProxyInvocationHandler$PipelineOptionsDisplayData.populateDisplayData(...:446)
at DisplayData.from(...)
at ProxyInvocationHandler$Serializer.serialize(...)
Caused by: java.lang.NullPointerException
at org.apache.beam.sdk.options.PipelineOptionsFactory.deserializeNode(...)
at org.apache.beam.sdk.options.ProxyInvocationHandler.getValueFromJson(...)
at
org.apache.beam.sdk.options.ProxyInvocationHandler$PipelineOptionsDisplayData.populateDisplayData(...:446)
at org.apache.beam.sdk.transforms.display.DisplayData.from(...)
at
org.apache.beam.sdk.options.ProxyInvocationHandler$Serializer.serialize(...)
at
org.apache.beam.sdk.util.construction.PipelineOptionsTranslation.toProto(...)
at org.apache.beam.runners.flink.FlinkJobInvoker.createJobInvocation(...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
