stankiewicz commented on code in PR #38490:
URL: https://github.com/apache/beam/pull/38490#discussion_r3274488536
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java:
##########
@@ -419,13 +453,31 @@ default void outputWithTimestamp(T value, Instant
timestamp) {
builder(value).setTimestamp(timestamp).output();
}
+ default void outputWithKind(T value, ValueKind valueKind) {
+ builder(value).setValueKind(valueKind).output();
+ }
+
default void outputWindowedValue(
T value,
Instant timestamp,
Collection<? extends BoundedWindow> windows,
PaneInfo paneInfo) {
builder(value).setTimestamp(timestamp).setWindows(windows).setPaneInfo(paneInfo).output();
}
+
+ default void outputWindowedValue(
Review Comment:
we don't want to add new interfaces to doFn. Approach is to leave
outputWindowedValue and if user/developer wants to output metadata, they need
to use outputBuilder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
