gemini-code-assist[bot] commented on code in PR #38582:
URL: https://github.com/apache/beam/pull/38582#discussion_r3280987659
##########
sdks/java/container/boot.go:
##########
@@ -195,9 +195,6 @@ func main() {
"-XX:+UseParallelGC",
"-XX:+AlwaysActAsServerClassMachine",
"-XX:-OmitStackTraceInFastThrow",
- // Crash and restart instead of throwing OutOfMemoryError which
may be caught by user or
- // framework code and leave things in a degraded state.
- "-XX:+ExitOnOutOfMemoryError",
}
Review Comment:
The pull request title indicates that the objective is to configure the JVM
to exit on `OutOfMemoryError`. However, this change removes the
`-XX:+ExitOnOutOfMemoryError` flag and its associated explanatory comment. This
appears to be a mistake in the cherry-pick process, as it directly contradicts
the stated goal of the PR. If the intention is to ensure the JVM exits on OOM
to avoid degraded states, these lines should be retained.
```suggestion
// Crash and restart instead of throwing OutOfMemoryError which
may be caught by user or
// framework code and leave things in a degraded state.
"-XX:+ExitOnOutOfMemoryError",
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
