shunping commented on code in PR #38586: URL: https://github.com/apache/beam/pull/38586#discussion_r3282615231
########## buildSrc/settings.gradle.kts: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import java.util.Properties + +pluginManagement { Review Comment: Here we need to add another `settings.gradle.kts` under buildSrc. The reason is three-folded: - First, buildSrc compiles as an isolated, nested build before the main project's settings or code are processed. It does not inherit the parent project's repository definitions. - Second, Transitive plugin dependencies (such as the Spotless formatting library dependencies) are resolved during a bootstrap phase before any code inside buildSrc/build.gradle.kts (including its repositories {} block) is compiled or evaluated. - Third, By creating buildSrc/settings.gradle.kts, it allows us to define a pluginManagement.repositories block specifically prior to buildSrc’s bootstrap phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
