damccorm commented on code in PR #38215:
URL: https://github.com/apache/beam/pull/38215#discussion_r3303916219
##########
sdks/python/apache_beam/ml/anomaly/transforms.py:
##########
@@ -400,7 +400,6 @@ def expand(
ret = (
input
- | beam.Reshuffle()
Review Comment:
> I remmoved reshffule as test_one_detector_1 was failing on the portable
runner in py 311 ml and tje ZScore learns in input order (score, then update)
and I found out that Reshuffle() can change that order so i saw wrong scores
(e.g. nan instead of 8.0 for the outlier row) that's why I removed it to keep
order stable for online detectors but if this is not the right approach i can
add reshuffle back and try to fix that test
Ok - we should not be changing transform/library functionality to make tests
pass unless the test is actually showing something that is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
