arunpandianp commented on code in PR #38430:
URL: https://github.com/apache/beam/pull/38430#discussion_r3307701155
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/ParDoOperation.java:
##########
@@ -46,12 +46,17 @@ public void process(Object elem) throws Exception {
}
@Override
- public void finish() throws Exception {
+ // Batch mode does not use this method and instead relies on
BatchModeUngroupingParDoFn
Review Comment:
Moved the comment above `@Override`.
> . Also, it isn't super obvious to me why someone reading this method is
going to want the information in the comment. It does seem like useful
information, but I wonder where someone needs to know it?
I guess it will help if someone wanted to know why
BatchModeUngroupingParDoFn is not calling finishKey() or is trying to make it
call finishKey. Thinking to leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
