lukecwik commented on a change in pull request #12934:
URL: https://github.com/apache/beam/pull/12934#discussion_r495223102
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -376,35 +385,76 @@ def get(self, instruction_id, bundle_descriptor_id):
Moves the ``BundleProcessor`` from the inactive to the active cache.
"""
- try:
- # pop() is threadsafe
- processor = self.cached_bundle_processors[bundle_descriptor_id].pop()
- except IndexError:
- processor = bundle_processor.BundleProcessor(
- self.fns[bundle_descriptor_id],
- self.state_handler_factory.create_state_handler(
- self.fns[bundle_descriptor_id].state_api_service_descriptor),
- self.data_channel_factory)
- self.active_bundle_processors[
Review comment:
The `pop` is thread safe but accessing
`self.cached_bundle_processors[bundle_descriptor_id]` is not guaranteed to be
so your right that some could be saved based upon your suggestion but it still
requires a self.lock surrounding
```
processor = self.cached_bundle_processors[bundle_descriptor_id].pop()
```
which will lead to us acquiring the mutex twice for the case when there is a
cached instance while the current imlementation only needs the mutex twice if
we need to create the BundleProcessor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
