Anuragp22 commented on PR #38749:
URL: https://github.com/apache/beam/pull/38749#issuecomment-4584244592
- 859715d: real assertions on the disabled-noop tests per the review
comment.
- 80c13c3: also initialize MetricsFlag from Pipeline.__init__. Previously
the init only ran in sdk_worker_main, so DirectRunner and other in-process
runners silently ignored the experiments. Mirrors the Java init point in
PipelineRunner.run and sits next to the existing FileSystems.set_options call.
Also updated the PR description with a note that disableBoundedTrieMetrics
will suppress Lineage data in Python because Python's Lineage uses
DelegatingBoundedTrie unconditionally. In Java that path is gated by
lineageRollupEnabled, but porting the dual-backend split is out of scope for
this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
