ibzib commented on pull request #12907: URL: https://github.com/apache/beam/pull/12907#issuecomment-699172961
> FWIW WindowTracing does not have to be the way it is. It is redundant with just having a variety of loggers in WindowTracing in which case all format strings could be constants. In a way, WindowTracing is circumventing the whole point of having the ability to make different loggers. I can see about removing it then. Current status: I ran into at least one place where we will need to make an exemption. Haven't checked yet if the plugin makes that possible. https://github.com/apache/beam/blob/ecedd3e654352f1b51ab2caae0fd4665403bd0eb/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkerHarnessHelper.java#L83 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
