gemini-code-assist[bot] commented on code in PR #38779:
URL: https://github.com/apache/beam/pull/38779#discussion_r3345247656
##########
sdks/java/io/hbase/build.gradle:
##########
@@ -50,3 +50,11 @@ dependencies {
testImplementation("org.apache.hbase:hbase-shaded-testing-util:$hbase_version")
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadow")
}
+
+configurations.all {
+ resolutionStrategy {
+ // TODO: remove after higher version of hbase (>2.6.5) contains this
minimum version.
+ force 'org.apache.commons:commons-configuration2:2.15.0'
Review Comment:
To maintain centralized dependency management, avoid hardcoding the
dependency coordinates and version here. Instead, reference the centralized
dependency from `BeamModulePlugin.groovy` using
`library.java.commons_configuration2`.
```
force library.java.commons_configuration2
```
##########
sdks/java/io/iceberg/hive/build.gradle:
##########
@@ -78,4 +78,8 @@ dependencies {
configurations.all {
// the fatjar "parquet-hadoop-bundle" conflicts with "parquet-hadoop" used
by org.apache.iceberg:iceberg-parquet
exclude group: "org.apache.parquet", module: "parquet-hadoop-bundle"
+ // TODO: remove after higher version of hbase (>2.6.5) contains this
minimum version.
+ resolutionStrategy {
+ force 'org.apache.commons:commons-configuration2:2.15.0'
Review Comment:
To maintain centralized dependency management, avoid hardcoding the
dependency coordinates and version here. Instead, reference the centralized
dependency from `BeamModulePlugin.groovy` using
`library.java.commons_configuration2`.
```
force library.java.commons_configuration2
```
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -725,7 +725,7 @@ class BeamModulePlugin implements Plugin<Project> {
commons_collections :
"commons-collections:commons-collections:3.2.2",
commons_compress :
"org.apache.commons:commons-compress:1.26.2",
commons_csv :
"org.apache.commons:commons-csv:1.8",
- commons_io :
"commons-io:commons-io:2.16.1",
+ commons_io :
"commons-io:commons-io:2.19.0",
Review Comment:
Define `commons_configuration2` centrally in `BeamModulePlugin.groovy` so
that it can be referenced across subprojects (like `hbase` and `iceberg`)
instead of hardcoding the version string in multiple places.
```
commons_configuration2 :
"org.apache.commons:commons-configuration2:2.15.0",
commons_io :
"commons-io:commons-io:2.19.0",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
