gemini-code-assist[bot] commented on code in PR #38798:
URL: https://github.com/apache/beam/pull/38798#discussion_r3351637582
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -3137,15 +3137,13 @@ class BeamModulePlugin implements Plugin<Project> {
def distTarBall = "${pythonRootDir}/build/apache-beam.tar.gz"
def packages = "gcp,test,aws,azure,dataframe"
def extra = project.findProperty('beamPythonExtra')
+ def installTargets = "${distTarBall}[${packages}]"
+ if (extra) {
+ installTargets = "${distTarBall}[${packages},${extra}]"
+ }
project.exec {
executable 'sh'
- args '-c', ". ${project.ext.envdir}/bin/activate && pip install
--pre --retries 10 ${distTarBall}[${packages}]"
- }
- if (extra) {
- project.exec {
- executable 'sh'
- args '-c', ". ${project.ext.envdir}/bin/activate && pip install
--pre --retries 10 ${distTarBall}[${extra}]"
- }
+ args '-c', ". ${project.ext.envdir}/bin/activate && pip install uv
&& uv pip install --pre ${installTargets}"
Review Comment:
To prevent flaky CI failures due to transient network issues, it is highly
recommended to retain the `--retries 10` option for both the `pip install uv`
command and the subsequent `uv pip install` command. `uv` supports the
`--retries` option just like `pip` does.
```
args '-c', ". ${project.ext.envdir}/bin/activate && pip install
--retries 10 uv && uv pip install --retries 10 --pre ${installTargets}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
