stankiewicz commented on code in PR #38786:
URL: https://github.com/apache/beam/pull/38786#discussion_r3354339152
##########
sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkLauncher.java:
##########
@@ -515,9 +515,11 @@ private void
invokeBuilderForPublishOnlyPipeline(PipelineBuilder<NexmarkOptions>
case UNRECOGNIZED:
case STOPPED:
case RUNNING:
+ case DRAINING:
// Keep going.
break;
case DONE:
+ case DRAINED:
Review Comment:
adding new states will be breaking change. can we split this PR into two.
One is adding drain() as method. second will add mapping to new states.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
