gemini-code-assist[bot] commented on code in PR #38819: URL: https://github.com/apache/beam/pull/38819#discussion_r3358866324
########## infra/keys/keys.yaml: ########## @@ -16,11 +16,11 @@ # Service Account Keys # This file contains the service account for the project, the account id # and the users authorized to use it -# service_accounts: -# - account_id: account_id -# display_name: account_@project_id.iam.gserviceaccount.com -# authorized_users: -# - email: "[email protected]" -# - email: "[email protected]" +service_accounts: +- account_id: hansel-tepal-gsoc-2026 + display_name: "Hansel Teapal GSoc 206" + authorized_users: + - email: "[email protected]" + - email: "[email protected]" Review Comment:  There are two issues with this configuration: 1. **Duplicate Key Override**: Defining `service_accounts:` here while keeping `service_accounts: []` on line 26 will cause the YAML parser to override this configuration with an empty list (or fail). The `service_accounts: []` line on line 26 must be removed. 2. **Typos in Display Name**: The display name `"Hansel Teapal GSoc 206"` contains typos ("Teapal" instead of "Tepal", and "GSoc 206" instead of "GSoC 2026"). ```yaml service_accounts: - account_id: hansel-tepal-gsoc-2026 display_name: "Hansel Tepal GSoC 2026" authorized_users: - email: "[email protected]" - email: "[email protected]" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
