chamikaramj commented on a change in pull request #12926:
URL: https://github.com/apache/beam/pull/12926#discussion_r495481482
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -1230,10 +1230,11 @@ def run_Read(self, transform_node, options):
if transform.source.id_label:
step.add_property(
PropertyNames.PUBSUB_ID_LABEL, transform.source.id_label)
- if transform.source.with_attributes:
- # Setting this property signals Dataflow runner to return full
- # PubsubMessages instead of just the data part of the payload.
- step.add_property(PropertyNames.PUBSUB_SERIALIZED_ATTRIBUTES_FN, '')
+
+ # Setting this property signals Dataflow runner to return full
+ # PubsubMessages instead of just the data part of the payload.
+ step.add_property(PropertyNames.PUBSUB_SERIALIZED_ATTRIBUTES_FN, '')
Review comment:
Is there any benchmark that we can run to make sure there's no
significant perf hit ?
I'm +1 for this simplification if there's no perf hit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
