arunpandianp commented on code in PR #38814: URL: https://github.com/apache/beam/pull/38814#discussion_r3371134373
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ComputationWorkExecutor.java: ########## Review Comment: We should be able to merge things into StreamingModeExecutionContext. Today ComputationWorkExecutor owns both StreamingModeExecutionContext and MapTaskExecutor. The tricky bit seems to be that MapTaskExecutor's creation depends on StreamingModeExecutionContext. So we need to create StreamingModeExecutionContext before the MapTaskExecutor. We could store MapTaskExecutor in StreamingModeExecutionContext after constructing both. I think we can do that separately, since it looks like it will pull in a bit of unrelated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
