scwhittle commented on code in PR #38842:
URL: https://github.com/apache/beam/pull/38842#discussion_r3371800272
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java:
##########
@@ -810,31 +811,32 @@ public boolean isEmpty() {
class StepContext extends DataflowExecutionContext.DataflowStepContext
implements StreamingModeStepContext {
- private final String stateFamily;
+ private final @Nullable String stateFamily;
private final Supplier<Closeable> scopedReadStateSupplier;
- private WindmillStateInternals<Object> stateInternals;
- private WindmillTimerInternals systemTimerInternals;
- private WindmillTimerInternals userTimerInternals;
+ private @Nullable WindmillStateInternals<Object> stateInternals;
Review Comment:
MonotonicNonNull might help reduce necessary annotations within functions
for some of these,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
