gemini-code-assist[bot] commented on code in PR #38789:
URL: https://github.com/apache/beam/pull/38789#discussion_r3382369636
##########
sdks/python/apache_beam/yaml/yaml_ml.py:
##########
@@ -282,8 +282,8 @@ def inference_output_type(self):
('model_id', Optional[str])])
[email protected]_handler_type('HuggingFacePipeline')
-class HuggingFacePipelineProvider(ModelHandlerProvider):
[email protected]_handler_type('HuggingFacePipelineModelHandler')
+class HuggingFacePipelineModelHandlerProvider(ModelHandlerProvider):
Review Comment:
Renaming the registered handler type from `HuggingFacePipeline` to
`HuggingFacePipelineModelHandler` is a breaking change for existing YAML
pipelines that use the old name. To maintain backward compatibility, you can
register both names by stacking the decorators.
```python
@ModelHandlerProvider.register_handler_type('HuggingFacePipelineModelHandler')
@ModelHandlerProvider.register_handler_type('HuggingFacePipeline')
class HuggingFacePipelineModelHandlerProvider(ModelHandlerProvider):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
