gemini-code-assist[bot] commented on code in PR #38877:
URL: https://github.com/apache/beam/pull/38877#discussion_r3383122925


##########
sdks/python/apache_beam/examples/wordcount_rust/README.md:
##########
@@ -33,7 +33,7 @@ This will compile the Rust code and build a Python package 
linked to it in the c
 To execute wordcount locally using the direct runner, execute the following 
from the wordcount_rust directory within the same virtual environment:
 
 ```bash
-python wordcount.py --runner DirectRunner --input * --output counts.txt
+python wordcount_rust.py --runner DirectRunner --input * --output counts.txt

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   Using an unquoted wildcard `*` for the `--input` argument will cause the 
shell to expand it to all files in the current directory before passing them to 
Python. This will lead to argument parsing errors (e.g., unrecognized 
arguments). Quote the wildcard to ensure it is passed literally to the Beam 
pipeline.
   
   ```suggestion
   python wordcount_rust.py --runner DirectRunner --input "*" --output 
counts.txt
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to