kanterov commented on a change in pull request #12919:
URL: https://github.com/apache/beam/pull/12919#discussion_r495858789



##########
File path: 
sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/ClickHouseIO.java
##########
@@ -473,7 +471,7 @@ private void flush() throws Exception {
    * @param table table name
    * @return table schema
    */
-  public static TableSchema getTableSchema(String jdbcUrl, String table) {
+  public static synchronized TableSchema getTableSchema(String jdbcUrl, String 
table) {

Review comment:
       Why is it synchronized? I don't see it doing any concurrent changes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to