gemini-code-assist[bot] commented on code in PR #38939:
URL: https://github.com/apache/beam/pull/38939#discussion_r3402744268
##########
runners/spark/job-server/spark_job_server.gradle:
##########
@@ -210,6 +210,8 @@ def portableValidatesRunnerTask(String name, boolean
streaming, boolean docker,
excludeTestsMatching
'org.apache.beam.sdk.transforms.FlattenTest.testFlattenWithDifferentInputAndOutputCoders2'
// TODO(https://github.com/apache/beam/issues/31231)
excludeTestsMatching
'org.apache.beam.sdk.transforms.RedistributeTest.testRedistributePreservesMetadata'
+ // Spark does not support side inputs in timers (added in #38363)
Review Comment:
To ensure this test exclusion is tracked and eventually resolved, please
create a GitHub issue and reference it with a `TODO` comment, following the
pattern used elsewhere in this file.
```
// TODO(https://github.com/apache/beam/issues/XXXXX) Spark does not
support side inputs in timers
```
##########
runners/spark/spark_runner.gradle:
##########
@@ -406,6 +406,8 @@ def validatesRunnerBatch =
tasks.register("validatesRunnerBatch", Test) {
excludeTestsMatching
'org.apache.beam.sdk.transforms.RedistributeTest.testRedistributePreservesMetadata'
// TODO(https://github.com/apache/beam/issues/32021)
excludeTestsMatching
'org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests.testBoundedSourceMetricsInSplit'
+ // Spark does not support side inputs in timers (added in #38363)
Review Comment:
Please use a `TODO` comment with a GitHub issue link to track the enablement
of this test, consistent with other test exclusions in this file.
```
// TODO(https://github.com/apache/beam/issues/XXXXX) Spark does not
support side inputs in timers
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
